Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Scala 2.11 & update dependencies #693

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

saeltz
Copy link
Collaborator

@saeltz saeltz commented Oct 17, 2022

Drops support for Scala 2.11 as discussed in #682.
Updates all dependencies, especially sbt-scoverage.

Fixes #682.
Closes #684.
Closes #685.
Closes #687.
Closes #688.
Closes #689.
Closes #690.
Closes #691.

@codecov-commenter
Copy link

Codecov Report

Base: 87.95% // Head: 87.82% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (490510f) compared to base (5c196a9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   87.95%   87.82%   -0.14%     
==========================================
  Files         141      141              
  Lines        1494     1519      +25     
  Branches       33      241     +208     
==========================================
+ Hits         1314     1334      +20     
- Misses        180      185       +5     
Impacted Files Coverage Δ
...c/main/scala/com/sksamuel/scapegoat/Feedback.scala 93.75% <100.00%> (ø)
...nspections/collections/ComparisonToEmptyList.scala 86.66% <0.00%> (-13.34%) ⬇️
...goat/inspections/collections/DuplicateMapKey.scala 92.30% <0.00%> (-7.70%) ⬇️
...n/scala/com/sksamuel/scapegoat/Configuration.scala 2.85% <0.00%> (-0.18%) ⬇️
...ksamuel/scapegoat/inspections/EmptyCaseClass.scala 100.00% <0.00%> (ø)
...muel/scapegoat/inspections/VariableShadowing.scala 100.00% <0.00%> (ø)
...capegoat/inspections/imports/DuplicateImport.scala 100.00% <0.00%> (ø)
...egoat/inspections/string/IllegalFormatString.scala 100.00% <0.00%> (ø)
...at/inspections/unneccesary/StoreBeforeReturn.scala 100.00% <0.00%> (ø)
...spections/string/LooksLikeInterpolatedString.scala 100.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saeltz saeltz marked this pull request as ready for review October 17, 2022 20:37
@@ -67,7 +67,7 @@ class Feedback(
adjustedLevel match {
case Levels.Error => reporter.error(pos, report)
case Levels.Warning => reporter.warning(pos, report)
case Levels.Info => reporter.info(pos, report, force = false)
case Levels.Info => reporter.echo(pos, report)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info was deprecated with Scala 2.12.

@saeltz saeltz requested review from mccartney and sksamuel October 18, 2022 07:01
Copy link
Collaborator

@mccartney mccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest the next version we release to be a major version for that reason.

Thank you for doing this.

@mccartney mccartney merged commit 4b6945a into scapegoat-scala:master Oct 20, 2022
@saeltz saeltz deleted the drop2.11 branch October 20, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoverage failure
3 participants