Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change severity in Checkstyle output to lowercase #624

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

JannikArndt
Copy link
Contributor

Hi! 👋

I'm currently adding this GitHub Action to our pipeline to display and annotate the code with the results from the scapegoat-run. Unfortunately, everything is just an "Annotation", because the GH Action expects the severity in the xml to be lowercase.

The DTD unfortunately doesn't define the severity attribute (https://checkstyle.org/dtds/configuration_1_3.dtd), but

So I think this change would make the output "more compliant" and make parsing the xml a but easier 😊

@sksamuel sksamuel merged commit 0b69fba into scapegoat-scala:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants