Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT for #378 (AsInstanceOf false positives) #432

Merged
merged 1 commit into from
Oct 3, 2020
Merged

UT for #378 (AsInstanceOf false positives) #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/test/scala/com/sksamuel/scapegoat/inspections/AsInstanceOfTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,22 @@ class AsInstanceOfTest extends InspectionTest {
compileCodeSnippet(code)
compiler.scapegoat.feedback.warnings.size shouldBe 0
}
"should not warn on GADT pattern matching (#378)" in {
val code =
"""
|sealed trait MyGADT[T]
|final case class VariantInt(value: Int) extends MyGADT[Int]
|final case class VariantString(value: String) extends MyGADT[String]
|
|def doStuff[T](gadt: MyGADT[T]): T = {
| gadt match {
| case VariantInt(value) => value
| case VariantString(value) => value
| }
|}
|""".stripMargin
compileCodeSnippet(code)
compiler.scapegoat.feedback.warnings.size shouldBe 0
}
}
}