Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafmt - pure refactoring #360

Merged
merged 2 commits into from
May 16, 2020
Merged

Conversation

mccartney
Copy link
Collaborator

Applying scalafmt from sbt

@mccartney mccartney marked this pull request as ready for review May 8, 2020 13:34
@mccartney
Copy link
Collaborator Author

I wonder why it hasn't been done earlier. Or what has changed recently.

@mwz
Copy link
Contributor

mwz commented May 9, 2020

I'm sure the codebase was formatted previously, but it looks like there's been a bunch of changes in 2.5, so perhaps some configuration has changed which forces it to be reformatted again.

@mccartney
Copy link
Collaborator Author

@mwz, would you want to double check or should I proceed with merging?

I am fine with either formatting styles. Just trying to limit down the changes, esp. that the formatting happens by itself.

@codecov-io
Copy link

Codecov Report

Merging #360 into master will increase coverage by 0.10%.
The diff coverage is 94.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   86.49%   86.59%   +0.10%     
==========================================
  Files         135      135              
  Lines        1474     1485      +11     
  Branches       36       36              
==========================================
+ Hits         1275     1286      +11     
  Misses        199      199              
Impacted Files Coverage Δ
src/main/scala/com/sksamuel/scapegoat/Level.scala 0.00% <0.00%> (ø)
...t/inspections/collections/JavaConversionsUse.scala 0.00% <0.00%> (ø)
...t/inspections/collections/PredefSeqIsMutable.scala 14.28% <0.00%> (ø)
src/main/scala/com/sksamuel/scapegoat/plugin.scala 34.37% <36.66%> (ø)
...tions/matching/PartialFunctionInsteadOfMatch.scala 60.00% <60.00%> (ø)
...t/inspections/string/EmptyInterpolatedString.scala 75.00% <75.00%> (ø)
...amuel/scapegoat/inspections/math/DivideByOne.scala 81.81% <81.81%> (ø)
...tions/collections/PredefTraversableIsMutable.scala 83.33% <83.33%> (ø)
...ections/collections/CollectionPromotionToAny.scala 87.50% <87.50%> (+0.83%) ⬆️
.../sksamuel/scapegoat/inspections/NoOpOverride.scala 90.00% <90.00%> (ø)
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7041e...fef3821. Read the comment docs.

@mccartney mccartney merged commit f2b29ea into scapegoat-scala:master May 16, 2020
@mccartney mccartney deleted the scalafmt3 branch May 16, 2020 19:18
@mccartney
Copy link
Collaborator Author

Ah. Not sure if it's because of #361, but I do have changes after running scalafmt from latest master again.

@mccartney mccartney mentioned this pull request May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants