Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding InspectionTest as a superclass for all inspection tests #332

Merged
merged 1 commit into from
Mar 30, 2020
+253 −718
Merged

Adding InspectionTest as a superclass for all inspection tests #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/test/scala/com/sksamuel/scapegoat/InspectionTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.sksamuel.scapegoat

import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

abstract class InspectionTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {}
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/AnyUseTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class AnyUseTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class AnyUseTest extends InspectionTest {

override val inspections = Seq(new AnyUse)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/AsInstanceOfTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.unsafe.AsInstanceOf
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

class AsInstanceOfTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class AsInstanceOfTest extends InspectionTest {

override val inspections = Seq(new AsInstanceOf)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/AvoidToMinusOneTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class AvoidToMinusOneTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class AvoidToMinusOneTest extends InspectionTest {

override val inspections = Seq(new AvoidToMinusOne)

Expand Down
8 changes: 0 additions & 8 deletions src/test/scala/com/sksamuel/scapegoat/inspections/ChainedPackageClauseTest.scala
View file
Open in desktop

This file was deleted.

7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/ConstantIfTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.unneccesary.ConstantIf
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

/** @author Stephen Samuel */
class ConstantIfTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class ConstantIfTest extends InspectionTest {

override val inspections = Seq(new ConstantIf)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/DoubleNegationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class DoubleNegationTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class DoubleNegationTest extends InspectionTest {

override val inspections = Seq(new DoubleNegation)

Expand Down
6 changes: 2 additions & 4 deletions src/test/scala/com/sksamuel/scapegoat/inspections/EitherGetTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.option.EitherGet
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

class EitherGetTest extends AnyFreeSpec with Matchers with PluginRunner {
class EitherGetTest extends InspectionTest {

override val inspections = Seq(new EitherGet)

Expand Down
12 changes: 2 additions & 10 deletions src/test/scala/com/sksamuel/scapegoat/inspections/FinalModifierOnCaseClassTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

class FinalModifierOnCaseClassTest
extends AnyFreeSpec
with Matchers
with PluginRunner
with OneInstancePerTest {
import com.sksamuel.scapegoat.InspectionTest
class FinalModifierOnCaseClassTest extends InspectionTest {

override val inspections = Seq(new FinalModifierOnCaseClass)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/FinalizerWithoutSuperTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.unsafe.FinalizerWithoutSuper
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

/** @author Stephen Samuel */
class FinalizerWithoutSuperTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class FinalizerWithoutSuperTest extends InspectionTest {

override val inspections = Seq(new FinalizerWithoutSuper)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/IsInstanceOfTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.unsafe.IsInstanceOf
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

/** @author Stephen Samuel */
class IsInstanceOfTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class IsInstanceOfTest extends InspectionTest {

override val inspections = Seq(new IsInstanceOf)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/LonelySealedTraitTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class LonelySealedTraitTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class LonelySealedTraitTest extends InspectionTest {

override val inspections = Seq(new LonelySealedTrait)

Expand Down
8 changes: 2 additions & 6 deletions src/test/scala/com/sksamuel/scapegoat/inspections/MaxParameterTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

class MaxParameterTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
import com.sksamuel.scapegoat.InspectionTest
class MaxParameterTest extends InspectionTest {

override val inspections = Seq(new MaxParameters)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/MethodReturningAnyTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.inference.MethodReturningAny
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

/** @author Stephen Samuel */
class MethodReturningAnyTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class MethodReturningAnyTest extends InspectionTest {

override val inspections = Seq(new MethodReturningAny)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/PublicFinalizerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class PublicFinalizerTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class PublicFinalizerTest extends InspectionTest {

override val inspections = Seq(new PublicFinalizer)

Expand Down
11 changes: 2 additions & 9 deletions src/test/scala/com/sksamuel/scapegoat/inspections/RedundantFinalModifierOnMethodTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class RedundantFinalModifierOnMethodTest
extends AnyFreeSpec
with Matchers
with PluginRunner
with OneInstancePerTest {
class RedundantFinalModifierOnMethodTest extends InspectionTest {

override val inspections = Seq(new RedundantFinalModifierOnMethod)

Expand Down
11 changes: 2 additions & 9 deletions src/test/scala/com/sksamuel/scapegoat/inspections/RedundantFinalModifierOnVarTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class RedundantFinalModifierOnVarTest
extends AnyFreeSpec
with Matchers
with PluginRunner
with OneInstancePerTest {
class RedundantFinalModifierOnVarTest extends InspectionTest {

override val inspections = Seq(new RedundantFinalModifierOnVar)

Expand Down
6 changes: 2 additions & 4 deletions src/test/scala/com/sksamuel/scapegoat/inspections/TryGetTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.unsafe.TryGet
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

/** @author Stephen Samuel */
class TryGetTest extends AnyFreeSpec with PluginRunner with Matchers {
class TryGetTest extends InspectionTest {

override val inspections = Seq(new TryGet)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/TypeShadowingTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class TypeShadowingTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class TypeShadowingTest extends InspectionTest {

override val inspections = Seq(new TypeShadowing)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/VarClosureTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class VarClosureTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class VarClosureTest extends InspectionTest {

override val inspections = Seq(new VarClosure)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/VarCouldBeValTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.unneccesary.VarCouldBeVal
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

class VarCouldBeValTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class VarCouldBeValTest extends InspectionTest {

override val inspections = Seq(new VarCouldBeVal)

Expand Down
8 changes: 2 additions & 6 deletions src/test/scala/com/sksamuel/scapegoat/inspections/VarUseTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

class VarUseTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
import com.sksamuel.scapegoat.InspectionTest
class VarUseTest extends InspectionTest {

override val inspections = Seq(new VarUse)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/VariableShadowingTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class VariableShadowingTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class VariableShadowingTest extends InspectionTest {

override val inspections = Seq(new VariableShadowing)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/WhileTrueTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
package com.sksamuel.scapegoat.inspections

import com.sksamuel.scapegoat.PluginRunner
import com.sksamuel.scapegoat.InspectionTest
import com.sksamuel.scapegoat.inspections.controlflow.WhileTrue
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers

/** @author Stephen Samuel */
class WhileTrueTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class WhileTrueTest extends InspectionTest {

override val inspections = Seq(new WhileTrue)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/collections/ArrayEqualsTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections.collections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class ArrayEqualsTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class ArrayEqualsTest extends InspectionTest {

override val inspections = Seq(new ArrayEquals)

Expand Down
7 changes: 2 additions & 5 deletions src/test/scala/com/sksamuel/scapegoat/inspections/collections/AvoidSizeEqualsZeroTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package com.sksamuel.scapegoat.inspections.collections

import com.sksamuel.scapegoat.PluginRunner
import org.scalatest.OneInstancePerTest
import org.scalatest.freespec.AnyFreeSpec
import org.scalatest.matchers.should.Matchers
import com.sksamuel.scapegoat.InspectionTest

/** @author Stephen Samuel */
class AvoidSizeEqualsZeroTest extends AnyFreeSpec with Matchers with PluginRunner with OneInstancePerTest {
class AvoidSizeEqualsZeroTest extends InspectionTest {

override val inspections = Seq(new AvoidSizeEqualsZero)

Expand Down
Loading