Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please compile support for Scala 3.0.0 #521

Open
Tracked by #53
mr-git opened this issue May 17, 2021 · 14 comments
Open
Tracked by #53

Please compile support for Scala 3.0.0 #521

mr-git opened this issue May 17, 2021 · 14 comments

Comments

@mr-git
Copy link

mr-git commented May 17, 2021

No description provided.

@saeltz
Copy link
Collaborator

saeltz commented May 26, 2021

Possibly duplicate of #391.

@mccartney
Copy link
Collaborator

I haven't had a chance to work with Scala 3 / Dotty before. Not sure what it takes and how are we from having scapegoat support that language.

@sksamuel
Copy link
Collaborator

I have Scapegoat working on Scala 3 in another repo.It's early days because we have to migrate every rule to new syntax since the reflection / compiler plugin stuff has changed considerably.

@mccartney greg happy to talk to you about this.

@mccartney
Copy link
Collaborator

Interesting. So is the plan to have a new project / fork, or will it possible to merge and maintain one code base?

@sksamuel
Copy link
Collaborator

sksamuel commented Jun 16, 2021 via email

@mccartney
Copy link
Collaborator

So based on the information above. The title doesn't do it justice as to work needed:

Please compile support for Scala 3.0.0

suggests it's about compiling/building/releasing a version. While in fact it's likely to be significant implementation effort.

@kpodsiad
Copy link

I have Scapegoat working on Scala 3 in another repo.It's early days because we have to migrate every rule to new syntax since the reflection / compiler plugin stuff has changed considerably.

@sksamuel is this available somewhere? I think it'll awesome to have even a few rules supported for Scala 3, rest of them might be added incrementally by interested people.

@kpodsiad
Copy link

@mccartney is there any ongoing effort with Scala 3 support?

@mccartney
Copy link
Collaborator

No. I don't think so. At least I am not aware

@sebarys
Copy link

sebarys commented Jul 19, 2024

is there any plan to support Scala 3/any place to track progress?

I've just checked https://docs.scala-lang.org/scala3/guides/migration/scala3-migrate.html dependency update and scapegoat plugin is blocking migration in my case:

[error]
[error] Incompatible Libraries:
[error] ("com.sksamuel.scapegoat" %% "scalac-scapegoat-plugin" % "2.1.6" % "scapegoat").cross(CrossVersion.full) (Full cross-version)

@saeltz
Copy link
Collaborator

saeltz commented Jul 19, 2024

No plan and no progress on the work @sksamuel started. It’s more or less a new library to be written. I suggest to use Scala 3 compiler linting instead.

@Johnnei
Copy link
Contributor

Johnnei commented Jul 25, 2024

I've been tinkering a bit with support for Scala 3 (as I want to move some of my projects to Scala 3 too), but the earlier comments are certainly right: Each inspection will need to be revisited to make compatible with the dotty compiler trees.

It will still take some more free nights to get it into a minimum viable state to propose it as an PR here.
https://github.com/Johnnei/scapegoat/tree/scala-3

@sksamuel
Copy link
Collaborator

No plan and no progress on the work @sksamuel started. It’s more or less a new library to be written. I suggest to use Scala 3 compiler linting instead.

I don't use Scala anymore, so I did not finish the migration.

@t1b00
Copy link

t1b00 commented Oct 24, 2024

Up on that, see issue #868 or my repo with a partial port (70 rules for now, working on more)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants