Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use hidden project configuration for dependency management #194

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Johnnei
Copy link
Collaborator

@Johnnei Johnnei commented Oct 10, 2024

Fixes #190

I do wonder how well this works with generated source though, will probably test this first with a few office projects before releasing this.

@Johnnei
Copy link
Collaborator Author

Johnnei commented Oct 11, 2024

As expected, this does cause a bunch of now missing delegation issues to mimic the compile scope. Might need to do some more mapping to support generated sources properly as well 🤔

@Johnnei Johnnei changed the title fix: Decouple Scapegoat/compile from Compile/compile fix: Use hidden project configuration for dependency management Nov 11, 2024
@Johnnei
Copy link
Collaborator Author

Johnnei commented Nov 11, 2024

After a lot of trying and tweaking, I concluded that #160 is essentially impossible without relying on commands to change state in sbt (like sbt-scoverage does) or going back to not having a scapegoat task (like wart-remover).
This change is a compromise, go back to the old style that didn't add the projectConfiguration for the actual task, but add a new hidden one to manage the dependency to avoid leaking it into published artifacts.

@Johnnei Johnnei merged commit 86434a2 into master Nov 25, 2024
1 check passed
@Johnnei Johnnei deleted the fix-double-compile branch November 25, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: scapegoat task is triggering default Compile task
1 participant