Feature - New Gridsystem core #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Column - Rows - container - Including sizing and media rules for different screens
|
To fix on this PR
Next Todo:
|
|
To fix on this PR
TODOS:
|
- Fixed responsiveness - added base unit 4px - rename prefix file - added screensizes
This was referenced Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
Describe what the pull-request is about
Merge this before #160 and #161
Flex based grid system
Good to know:
The gutter and padding is included in the same calculation, instead of margin + padding, because the flex-basis will be complicated solution. This solution contains padding + padding instead for the gutter and padding on the columns
Nesting of grid is not something we will have ( maybe in the future)
Solving issue
Add which issue this pull-request solves by adding # plus the number of the issue (for example #123)
Fixes: scania/corporate-ui#589
How to test
Add description how to test if possible
Screenshots
If applicable, add screenshots to help explain
Additional context
Add any other context about the pull-request here.
Internet explorer breaks on the next row, height of the row is not increased as aspected