Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/stencil 2 upgrade #155

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Improvement/stencil 2 upgrade #155

merged 2 commits into from
Nov 10, 2020

Conversation

helloimela
Copy link
Contributor

@helloimela helloimela commented Nov 3, 2020 •
edited
Loading

Describe pull-request

  • Update corporate-ui with Stencil 2, update CDN setup to follow stencil store setup

How to test

  1. Test together with corporate UI (Improvement/upgrade stencil 2 corporate-ui#594)
  2. Check in both NPM and CDN ways of loading script
  3. Check if all components work
  4. Check in mobile if navigation works properly

Screenshots
If applicable, add screenshots to help explain

Additional context
Add any other context about the pull-request here.

Ela Yudhanira added 2 commits October 30, 2020 08:52
Update store with stencil store structure
2f502e3
Stencil 2 upgrade store
436629e 
- Update CDN store to follow stencil store setup
@helloimela helloimela mentioned this pull request Nov 3, 2020
Merged
mmexvr
mmexvr approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@mmexvr mmexvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@helloimela helloimela merged commit 2076dde into master Nov 10, 2020
@helloimela helloimela deleted the improvement/stencil_2_upgrade branch November 10, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmexvr mmexvr mmexvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helloimela @mmexvr