Improvement - c-table add styles for component with shadow root #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! We are still waiting for a more finalized and approved design from our designers and will continue from that |
|
This PR contains changes that were asked for in your previous pull-request scania/corporate-ui#565 changes are med in another PR scania/corporate-ui#569 |
mmexvr
approved these changes
Jun 25, 2020
|
We made some changes from your PR #145 in this pull-request here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
Solving issue
Fixes: scania/corporate-ui#551
How to test
Test together with scania/corporate-ui#569