Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved bug with button active showing above navigation z-index #140

Merged
merged 1 commit into from
May 5, 2020

Conversation

mmexvr
Copy link
Member

@mmexvr mmexvr commented Apr 29, 2020

Describe pull-request
Describe what the pull-request is about
Increased the z-index for navigation because of the z-index: 1 for the buttons which is default in bootstrap 4 on active.

Solving issue
Add which issue this pull-request solves by adding # plus the number of the issue (for example #123)
Fixes: scania/corporate-ui#540

How to test
Add description how to test if possible

  1. Create a page with button with active on it, e.g button primary active

Screenshots
If applicable, add screenshots to help explain
Solved:
image

Additional context
Add any other context about the pull-request here.
Keep in mind, there might be other elements that have it that we will implement in the future from bootstrap.

@mmexvr mmexvr added the Bug Something isn't working label Apr 29, 2020
@mmexvr mmexvr requested a review from helloimela April 29, 2020 13:48
@mmexvr mmexvr self-assigned this Apr 29, 2020
@helloimela helloimela merged commit 4476c15 into master May 5, 2020
@helloimela helloimela deleted the bug/button-z-index-problem branch May 5, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong z-index on active button in buttons groups
2 participants