Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added adoptedStylesheet to all components #550

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Added adoptedStylesheet to all components #550

merged 2 commits into from
Mar 20, 2020

Conversation

helloimela
Copy link
Contributor

  • Update components to use adoptedStylesheets for styling
  • Add a new file to contain the function themeStyle()

@helloimela
Added adoptedStylesheet to all components
b5bd969 
- Update components to use adoptedStylesheets for styling
@helloimela helloimela requested a review from awinny March 19, 2020 15:07
@helloimela helloimela self-assigned this Mar 19, 2020
@helloimela
Fixed test to pass travis build
dff8a7f 
- Changed from ts file to js file
- Comment failed e2e spec test and will fix it later when we have more time
@helloimela helloimela added the Improvement Improvement of already existing feature label Mar 20, 2020
awinny
awinny approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@awinny awinny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍
Should change rendering in tempalte to object instead of array later on though.
Also notice that instead of sending arguments themeStyle we could simply do:
themeStyle.call(this)

@awinny awinny merged commit 8f1c486 into feature/Create_cookie_component Mar 20, 2020
@awinny awinny deleted the improvement/add_adaptedStylesheet_to_all_components branch March 20, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awinny awinny awinny approved these changes

Assignees

@helloimela helloimela

Labels
Improvement Improvement of already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helloimela @awinny