Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/script for cdn solution #516

Merged
merged 5 commits into from
Dec 11, 2019

Conversation

helloimela
Copy link
Contributor

@helloimela helloimela commented Dec 9, 2019

Describe pull-request

  • Create a script to support CDN way
  • Make sure stencil is loaded in IE by moving script order
  • Added renamer task to the build task

How to test

NOTE

  • Right now it only works on 'npm run build'
  • Should think about task automation, renamer task won't run when 'watch' flag added to stencil
  • Or just use corporate-ui-dev.js on development environment (if using CDN in local)

Ela Yudhanira added 4 commits December 4, 2019 10:56
- Need to test in IE
- Added renamer task to the build task
- Make sure stencil is loaded in IE by moving script order
@helloimela helloimela requested a review from awinny December 9, 2019 15:27
@helloimela helloimela self-assigned this Dec 9, 2019
@helloimela helloimela added the Improvement Improvement of already existing feature label Dec 9, 2019
@helloimela helloimela requested a review from mmexvr December 9, 2019 15:29
- Remove corporate-ui folder
@mmexvr
Copy link
Member

mmexvr commented Dec 11, 2019

Looks good

@mmexvr mmexvr merged commit 2392559 into master Dec 11, 2019
@mmexvr mmexvr deleted the improvement/script_for_CDN_solution branch December 11, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement of already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants