-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(header-dropdown): chevron icon rotation #965
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Playwright test resultsDetails 421 tests across 146 suites Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
@max-umain - Please rebase locally with the latest develop and push with force. That should fix the unit tests. |
94bfab8
to
4b721e3
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@max-umain This would ned another rebase to develop, then I will review 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Describe pull-request
Fixes the header dropdown chevron to rotate when the element is clicked.
Issue Linking:
How to test
Checklist before submission
npm run build-all
without errorsSuggested test steps
Screenshots
None
Additional context
None