Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header-dropdown): chevron icon rotation #965

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

max-umain
Copy link
Collaborator

@max-umain max-umain commented Jan 15, 2025

Describe pull-request

Fixes the header dropdown chevron to rotate when the element is clicked.

Issue Linking:

How to test

  1. Open storybook
  2. Go to Patterns → Navigation → Few Navigation Items.
  3. Make sure that your window is wide enough that it shows the chevron icon element "Wheel Types" in the header without having to open the side menu
  4. Click the "Wheel Types" button

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

None

Additional context

None

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-965.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Playwright test results

passed  420 passed
skipped  1 skipped

Details

stats  421 tests across 146 suites
duration  1 minute, 4 seconds
commit  4b721e3

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@theJohnnyMe
Copy link
Contributor

@max-umain - Please rebase locally with the latest develop and push with force. That should fix the unit tests.

@max-umain max-umain force-pushed the fix/header-dropdown-chevron branch from 94bfab8 to 4b721e3 Compare January 17, 2025 15:25
Copy link
Collaborator

@ckrook ckrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-umain This would ned another rebase to develop, then I will review 🙌

@theJohnnyMe theJohnnyMe changed the title fix(header): fix header dropdown chevron icon rotation when clicked fix(header-dropdown): chevron icon rotation Jan 20, 2025
Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ckrook ckrook self-requested a review January 20, 2025 17:53
@Lunkan89 Lunkan89 merged commit d6e319f into develop Jan 21, 2025
4 checks passed
@Lunkan89 Lunkan89 deleted the fix/header-dropdown-chevron branch January 21, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants