Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text-field): expose focusElement() method #908

Merged
merged 19 commits into from
Jan 16, 2025
Merged

Conversation

patrikhultgren
Copy link
Collaborator

@patrikhultgren patrikhultgren commented Dec 16, 2024

Describe pull-request

Exposes focusTextField method for the text field component.

Issue Linking:

How to test

Call the focusTextField() method programmatically for a tds-text-field element.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • Not breaking production behavior

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-908.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Playwright test results

passed  420 passed
skipped  1 skipped

Details

stats  421 tests across 146 suites
duration  1 minute, 4 seconds
commit  278ff19

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@patrikhultgren patrikhultgren changed the title feat: expose focusTextField method for the text field component feat: expose focusTextField() method for the text field component Dec 16, 2024
@patrikhultgren patrikhultgren changed the title feat: expose focusTextField() method for the text field component feat(text-field): expose focusTextField() method Dec 16, 2024
@nathalielindqvist
Copy link
Contributor

@patrikhultgren thank you for this contribution! 🎉 Just to keep you in the loop, the majority of IXIB will be off during the holidays so it might take longer than usual to get this approved. But rest assure that more people will look into this once they are back from vacation :)

@theJohnnyMe theJohnnyMe requested a review from mJarsater January 13, 2025 15:41
Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Lunkan89 and others added 2 commits January 16, 2025 13:36
* test: saving screenshots of failing tests

* test: corrected output directory

* test: fix output directory path

* test: using artifacts upload v4

* test: reverting to older ubuntu version

* test: lowering artifacts retention days
@theJohnnyMe theJohnnyMe changed the title feat(text-field): expose focusTextField() method feat(text-field): expose focusElement() method Jan 16, 2025
@theJohnnyMe theJohnnyMe merged commit 1298756 into develop Jan 16, 2025
4 checks passed
@theJohnnyMe theJohnnyMe deleted the feat/focus branch January 16, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants