Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2956 Output error messages for configurable products on add all to cart #23

Merged
merged 2 commits into from
Jul 23, 2021
Merged

#2956 Output error messages for configurable products on add all to cart #23

merged 2 commits into from
Jul 23, 2021

Conversation

riha112
Copy link
Contributor

@riha112 riha112 commented Jul 23, 2021

Original issue: scandipwa/scandipwa#2956

In this PR:

  • Instead of outputting error only for one product added so that all products are checked
  • Changed error message to match Magento style error messages (had to use GraphQlInputException with Phrase so that when returning graphql response the data is stored in correct location)

@riha112 riha112 mentioned this pull request Jul 23, 2021
Merged
@carinadues carinadues merged commit 64b2e07 into scandipwa:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejnshtein ejnshtein ejnshtein approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riha112 @ejnshtein @carinadues