Improved with NoSuchEntityException catch for item in stock #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referencing the original issue |
alfredsgenkins
requested changes
Jan 21, 2021
src/Model/Resolver/EntityUrl.php
Outdated
Comment on lines
144
to
149
| try { | ||
| $isInStock = $this->stockItemRepository->get($id)->getIsInStock(); | ||
| throw new NoSuchEntityException(); | ||
| } catch (NoSuchEntityException $e) { | ||
| // Ignoring error is safe | ||
| } |
There was a problem hiding this comment.
What is going on here? So you throw the error manually to achieve what? This seem to me to work OK even without doing that throw new NoSuchEntityException();.
| @@ -139,7 +139,13 @@ public function resolve( | |||
| $collection = $this->productCollectionFactory->create() | |||
| ->addAttributeToFilter('status', ['eq' => Status::STATUS_ENABLED]); | |||
| $product = $collection->addIdFilter($id)->getFirstItem(); | |||
| $isInStock = $this->stockItemRepository->get($id)->getIsInStock(); | |||
| $isInStock = false; | |||
There was a problem hiding this comment.
Hey!
If stockItemRepository fails to get stock status by product id is it really means that this product is out of stock?
There was a problem hiding this comment.
@AleksandrsKondratjevs Technically yes. If we are unable to get the product, how can we verify the stock?
alfredsgenkins
approved these changes
Jan 22, 2021
| try { | ||
| $isInStock = $this->stockItemRepository->get($id)->getIsInStock(); | ||
| } catch (NoSuchEntityException $e) { | ||
| // Ignoring error is safe |
There was a problem hiding this comment.
Instead of ignoring the error I would return null; but it is a preference. Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.