Changed the order of required vars PHP8 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables since this is a rule in php 8
zans-laksa
suggested changes
May 5, 2022
src/Model/Template/Filter.php
Outdated
Comment on lines
75
to
81
| Widget $widget, | ||
| $variables = [], | ||
| array $directiveProcessors = [], | ||
| array $availableFilters, | ||
| array $widgetUnescapedParams, | ||
| array $widgetCustomParamsHandlers | ||
| array $widgetCustomParamsHandlers, | ||
| $variables = [], | ||
| array $directiveProcessors = [] | ||
| ) { |
There was a problem hiding this comment.
So you have changed the order of the parameters of the constructor.
But did you check where this class is created? Does it break since arguments are passed in the wrong order? :)
There was a problem hiding this comment.
Optional arguments aren't necessary here.
Please return the order of arguments and remove the default values.
Then add a fallback for arguments, that had a default value, when you pass them to the parent constructor.
See the line 101 as the example.
zans-laksa
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scandipwa/scandipwa#4122
Changed the position of required and optional(with default values) variables since this is a rule in PHP 8
Comment in the task