Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSET-4456: Drop testing for Go 1.19 and add 1.21 #53

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

martin-majlis-s1
Copy link
Collaborator

Jira Link: https://sentinelone.atlassian.net/browse/DSET-4456

🥅 Goal

Go 1.19 is no longer supported - https://endoflife.date/go, and also open telemetry is no longer testing for 1.19 - open-telemetry/opentelemetry-collector-contrib#25116 - we should do the same.

🛠️ Solution

Do the same as open telemetry - drop 1.19 and add 1.21.

🏫 Testing

Unit testing

Copy link
Collaborator

@tomaz-s1 tomaz-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-majlis-s1 martin-majlis-s1 added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 784603b Aug 23, 2023
9 of 10 checks passed
@martin-majlis-s1 martin-majlis-s1 deleted the DSET-4456-drop-support-for-go-1.19 branch August 23, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants