Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/ZENKO-436 retrieve correct read location constraint #1272

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented Jun 7, 2018

(cherry picked from commit b7fb379)

  • some typo fixes

older pr: #1264

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

rahulreddy
rahulreddy previously approved these changes Jun 7, 2018
@alexanderchan-scality alexanderchan-scality force-pushed the bugfix/ZENKO-436/pickReadLocationFix branch from fa77a1b to f9274e1 Compare June 8, 2018 20:24
@ironman-machine ironman-machine dismissed stale reviews from jonathan-gramain and rahulreddy June 8, 2018 20:24

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

rahulreddy
rahulreddy previously approved these changes Jun 8, 2018
@rahulreddy rahulreddy closed this Jun 12, 2018
@rahulreddy rahulreddy reopened this Jun 12, 2018
@rahulreddy
Copy link
Collaborator

@bert-e help

@rahulreddy rahulreddy closed this Jun 12, 2018
@rahulreddy rahulreddy reopened this Jun 12, 2018
@rahulreddy
Copy link
Collaborator

@bert-e help

@alexanderchan-scality alexanderchan-scality changed the title bf: ZENKO-436 retrieve correct read location constraint bugfix/ZENKO-436 retrieve correct read location constraint Jun 13, 2018
@bert-e
Copy link
Contributor

bert-e commented Jun 13, 2018

Hello alexanderchan-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@alexanderchan-scality
Copy link
Contributor Author

@bert-e help

@bert-e
Copy link
Contributor

bert-e commented Jun 13, 2018

Help page

The following options and commands are available at this time.

Options

name description privileged
➡️ bypass_tester_approval Bypass the pull request testers' approval
➡️ bypass_commit_size Bypass the check on the size of the changeset TBA
➡️ after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
➡️ bypass_incompatible_branch Bypass the check on the source branch prefix
➡️ bypass_author_approval Bypass the pull request author's approval
➡️ bypass_build_status Bypass the build and test status
➡️ wait Instruct Bert-E not to run until further notice.
➡️ create_pull_requests Allow the creation of integration pull requests.
➡️ bypass_jira_check Bypass the Jira issue check
➡️ bypass_peer_approval Bypass the pull request peers' approval
➡️ unanimity Change review acceptance criteria from one reviewer at least to all reviewers
➡️ no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead

Commands

name description privileged
➡️ build Re-start a fresh build TBA
➡️ reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.
➡️ status Print Bert-E's current status in the pull request TBA
➡️ retry Re-start a fresh build TBA
➡️ clear Remove all comments from Bert-E from the history TBA
➡️ help Print Bert-E's manual in the pull request.
➡️ force_reset Delete integration branches & pull requests, and restart merge process from the beginning.

@rahulreddy
Copy link
Collaborator

@bert-e reset

@bert-e
Copy link
Contributor

bert-e commented Jun 13, 2018

Reset complete

I have successfully deleted this pull request's integration branches.

@rahulreddy
Copy link
Collaborator

@bert-e build

@bert-e
Copy link
Contributor

bert-e commented Jun 13, 2018

Not implemented

This command will be implemented soon.

@rahulreddy
Copy link
Collaborator

@bert-e bypass_jira_check

@rahulreddy
Copy link
Collaborator

@bert-e clear

@bert-e
Copy link
Contributor

bert-e commented Jun 13, 2018

Not implemented

This command will be implemented soon.

The following options are set: bypass_jira_check

@rahulreddy rahulreddy closed this Jun 13, 2018
@rahulreddy rahulreddy reopened this Jun 13, 2018
@alexanderchan-scality
Copy link
Contributor Author

@bert-e force_reset

@bert-e
Copy link
Contributor

bert-e commented Jun 14, 2018

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: bypass_jira_check

(cherry picked from commit b7fb379)
+ some typo fixes
@alexanderchan-scality alexanderchan-scality force-pushed the bugfix/ZENKO-436/pickReadLocationFix branch from f9274e1 to 79b7899 Compare June 14, 2018 23:32
@ironman-machine ironman-machine dismissed stale reviews from rahulreddy and jonathan-gramain June 14, 2018 23:32

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@bert-e
Copy link
Contributor

bert-e commented Jun 14, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • 2 peers

The following options are set: bypass_jira_check

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@rahulreddy rahulreddy merged commit 70049b7 into development/8.0 Jun 15, 2018
@rahulreddy rahulreddy deleted the bugfix/ZENKO-436/pickReadLocationFix branch June 15, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants