Bf/zenko 436 pick read location fix #1264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-gramain
previously approved these changes
Jun 4, 2018
| @@ -0,0 +1,26 @@ | |||
| /** | |||
| * checkReadLocation - verify that a bucket's default read location exists | |||
| * a specified read data locator | |||
There was a problem hiding this comment.
typo exists [for] a specified ...
| * @param {string} locationName - location constraint | ||
| * @param {string} objectKey - object key | ||
| * @param {string} bucketName - bucket name | ||
| * @return {Object | null} return object if location exists; otherwise, null |
There was a problem hiding this comment.
minor: I suggest a more descriptive comment about the returned value, e.g. returns the data storage location?
(cherry picked from commit b7fb379) + some typo fixes
alexanderchan-scality
force-pushed
the
bf/ZENKO-436-pickReadLocationFix
branch
from
36f3ee6
to
46f3f1a
Compare
ironman-machine
dismissed
jonathan-gramain’s stale review
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
philipyoo
approved these changes
Jun 7, 2018
philipyoo
reviewed
Jun 7, 2018
| @@ -0,0 +1,27 @@ | |||
| /** | |||
| * checkReadLocation - verify that a bucket's default read location exists | |||
| * a for specified read data locator | |||
jonathan-gramain
approved these changes
Jun 7, 2018
|
closed in favor of #1272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit b7fb379)