Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurse when getting list of what requires a package to remove duplicates #1463

Closed
wants to merge 1 commit into from
Closed

Recurse when getting list of what requires a package to remove duplicates #1463

wants to merge 1 commit into from

Conversation

TeddyAndrieux
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux commented Jul 23, 2019 •
edited
Loading

Component:

'salt'

Context:

If several version of a package is available in our repos then the module metalk8s_package_manager.list_pkg_deps will take the wrong one

Summary:

Does not use --recursive with repoquery to always take the closer requires version instead of the last one.

Acceptance criteria:

Have the right list of package when 2 version available in the same repo

[root@bootstrap ~]# repoquery --whatrequires --qf '%{NAME} %{VERSION}-%{RELEASE}' kubelet-1.12.9 --disablerepo '*' --enablerepo 'metalk8s-*' --recursive
calico-cni-plugin 3.8.0-1.el7
kubelet 1.12.9-0
kubelet 1.13.7-0
kubernetes-cni 0.7.5-0
[root@bootstrap ~]# salt-call metalk8s_package_manager.list_pkg_deps kubelet 1.12.9 fromrepo="metalk8s-*"
local:
    ----------
    calico-cni-plugin:
        3.8.0-1.el7
    kubelet:
        1.12.9
    kubernetes-cni:
        0.7.5-0

Fixes: #1455

@TeddyAndrieux
Recurse when getting list of what requires a package to remove duplic…
f64b14c 
…ates

Does not use `--recursive` with repoquery to always take the closer
requires version instead of the last one.

Fixes: #1455
@TeddyAndrieux TeddyAndrieux requested a review from a team July 23, 2019 10:04
@bert-e
Copy link
Contributor

bert-e commented Jul 23, 2019

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 23, 2019

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jul 23, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@gdemonet gdemonet self-assigned this Jul 23, 2019
@TeddyAndrieux
Copy link
Collaborator Author

Already done by #1477

@TeddyAndrieux TeddyAndrieux deleted the bugfix/1455-package-manager-list-deps branch July 31, 2019 06:54
@bert-e bert-e restored the bugfix/1455-package-manager-list-deps branch July 31, 2019 06:54
@TeddyAndrieux TeddyAndrieux deleted the bugfix/1455-package-manager-list-deps branch July 31, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gdemonet gdemonet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyAndrieux @bert-e @gdemonet