Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and correct references to docker terms in buildchain #947

Closed
jbertran opened this issue Apr 5, 2019 · 0 comments
Closed

Review and correct references to docker terms in buildchain #947

jbertran opened this issue Apr 5, 2019 · 0 comments
Labels
kind:debt Technical debt topic:build Anything related to building steps

Comments

@jbertran
Copy link
Contributor

jbertran commented Apr 5, 2019

In the buildchain image, local_image and remote_image, we define and use tags, versions, repositories and registries in a manner that is not entirely accurate or consistent.

This needs to be fixed, for the sanity of future buildchain maintainers.

Originally posted by @slaperche-scality in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MjIyNzM4NDQ4/pull_request_reviews/more_threads
@jbertran jbertran added topic:build Anything related to building steps kind:debt Technical debt labels Apr 5, 2019
@jbertran jbertran mentioned this issue Apr 5, 2019
Merged
gdemonet added a commit that referenced this issue Jul 23, 2019
@gdemonet
Simplify DockerTag signature
11c2ff6 
Issue: #947
gdemonet added a commit that referenced this issue Jul 23, 2019
@gdemonet
Clean-up Docker terms in buildchain
2179b89 
We attempt to provide a more obvious API by using accurate names and
concepts from the Docker concepts. In particular, our previous use of
"registry" actually meant "repository". We also make sure that image
"tags" actually represent both the name and version.

Fixes: #947
gdemonet added a commit that referenced this issue Jul 25, 2019
@gdemonet
Clean-up Docker terms in buildchain
a7bf24c 
We attempt to provide a more obvious API by using accurate names and
concepts from the Docker concepts. In particular, our previous use of
"registry" actually meant "repository". We also make sure that image
"tags" actually represent both the name and version.

Fixes: #947
@gdemonet gdemonet mentioned this issue Jul 25, 2019
Merged
gdemonet added a commit that referenced this issue Jul 26, 2019
@gdemonet
Clean-up Docker terms in buildchain
0a740f5 
We attempt to provide a more obvious API by using accurate names and
concepts from the Docker concepts. In particular, our previous use of
"registry" actually meant "repository". We also make sure that image
"tags" actually represent both the name and version.

Fixes: #947
gdemonet added a commit that referenced this issue Jul 26, 2019
@gdemonet
Clean-up Docker terms in buildchain
0f0cf5c 
We attempt to provide a more obvious API by using accurate names and
concepts from the Docker concepts. In particular, our previous use of
"registry" actually meant "repository". We also make sure that image
"tags" actually represent both the name and version.

Fixes: #947
gdemonet added a commit that referenced this issue Jul 29, 2019
@gdemonet
Clean-up Docker terms in buildchain
db24a5a 
We attempt to provide a more obvious API by using accurate names and
concepts from the Docker concepts. In particular, our previous use of
"registry" actually meant "repository". We also make sure that image
"tags" actually represent both the name and version.

Fixes: #947
@bert-e bert-e closed this as completed in a84576c Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:debt Technical debt topic:build Anything related to building steps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbertran