packaging: refactor build list generation

Issue: #1530
scality · Sep 18, 2019 · e17c529 · e17c529
1 parent 0e4f266
commit e17c529
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/buildchain/buildchain/packaging.py b/buildchain/buildchain/packaging.py
@@ -193,11 +193,17 @@ def _package(name: str, sources: List[Path]) -> targets.Package:
     ),
 }
 
-_TO_BUILD_PKG_NAMES : List[str] = []
 
-for pkgs in TO_BUILD.values():
-    for pkg in pkgs:
-        _TO_BUILD_PKG_NAMES.append(pkg.name)
+def _list_packages_to_build(
+    pkg_cats: Dict[str, Tuple[targets.Package, ...]]
+) -> List[str]:
+    return [
+        pkg.name for pkg_list in pkg_cats.values()
+        for pkg in pkg_list
+    ]
+
+
+_TO_BUILD_PKG_NAMES : List[str] = _list_packages_to_build(TO_BUILD)
 
 # All packages not referenced in `TO_BUILD` but listed in `versions.PACKAGES`
 # are supposed to be downloaded.