Improvement/arsnn 2 convert project to js #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamlardier
force-pushed
the
improvement/ARSNN-2-convert-project-to-JS
branch
11 times, most recently
from
b5d334f
to
b6ea036
Compare
williamlardier
force-pushed
the
improvement/ARSNN-2-convert-project-to-JS
branch
from
b6ea036
to
435c743
Compare
XinLi0207
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix a yarn bug with sub-sub depdendencies relying on the
preparescript.In short, using a typescript "sub-sub-dependency" with a prepare step in Arsenal breaks yarn install commands when we bump Arsenal in Vault2, Backbeat or Cloudserver with random
Extracting tar content of undefined failederrors. This issue was faced in the past when Arsenal was migrated to typescript as well, but the documented fix (--network-concurrency 1) is not working here (and I tried a lot of things without success). Seems to be a yarn v1 bug.