Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/artesca 6419 initial http agent wrapper #2

Conversation

williamlardier
Copy link
Contributor

Introduces Arsenal-Networking, as a centralized way to enforce common networking configuration across our components.

First commit: creating the project configuration files, including prettier, to enforce code style.
Second commit: initializing the project (typescript) with required dependencies.
Third commit: adding the abstraction layer for the http(s) Agent classes, to enforce the TCP connection reuse, as keepAlive alone is not enough in case of high load, as maxSockets is, by default, equal to Infinity.
Last commit: Adding a simple test workflow to ensure that the project builds and pass syntax checks.

@williamlardier williamlardier requested a review from a user November 28, 2022 16:47
@francoisferrand
Copy link

  • How does this differ from agentkeepalive (which we use in some parts of the code only) ? Would be better if don't need to reinvent the wheel
  • In any case, this repo should be renamed (before it becomes more complicated, as the repo would be used) : either it is a separate component, and it should not be named "arsenal" ; or it is part of arsenal and it should then stay in that repo...

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@williamlardier
Copy link
Contributor Author

williamlardier commented Dec 5, 2022

Post discussion with @francoisferrand , we'll reduce the scope of the repo to only HTTP Agents for now, and rename the repository to httpagent to make it clear.
This repository will introduce a bit more than something like agentkeepalive because we also enforce scality-specific environment variables for the configuration.

@williamlardier williamlardier force-pushed the improvement/ARTESCA-6419-initial-http-agent-wrapper branch from d22332d to c09ac9f Compare December 5, 2022 15:24
@williamlardier williamlardier merged commit 5a3d96b into development/8.1 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants