FT: AZURE GET #835
Merged
FT: AZURE GET #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas2bert
force-pushed
the
azure/get
branch
4 times, most recently
from
61d1df4
to
0508ee4
Compare
LaurenSpiegel
suggested changes
Jul 26, 2017
lib/api/objectGet.js
Outdated
| @@ -106,6 +111,11 @@ function objectGet(authInfo, request, returnTagCount, log, callback) { | |||
| // objMD.location is just a string | |||
| dataLocator = Array.isArray(objMD.location) ? | |||
| objMD.location : [{ key: objMD.location }]; | |||
|
|
|||
| if (dataLocator && dataLocator[0] && | |||
There was a problem hiding this comment.
add comment:
// if the data backend is azure, there will only ever be at most one item in the dataLocator array
| keys.forEach(key => { | ||
| describe(`${key.describe} size`, () => { | ||
| before(done => { | ||
| s3.putObjectAsync({ |
|
|
||
| describe('returning error', () => { | ||
| before(done => { | ||
| s3.putObjectAsync({ |
| }); | ||
|
|
||
| it('should return an error on get done to object deleted ' + | ||
| 'from AWS', done => { |
| azureStreamingOptions, err => { | ||
| if (err) { | ||
| const log = createLogger(reqUids); | ||
| log.error('err from Azure GET data backend', |
There was a problem hiding this comment.
does this actually log an error "not found" on your error test? Even if it does, we should consider doing a head call to azure first to see if we are going to get back an error so we can fail more gracefully.
LaurenSpiegel
approved these changes
Jul 27, 2017
dora-korpar
approved these changes
Jul 27, 2017
| return azureContainerName; | ||
| }; | ||
|
|
||
| utils.getKeysForTestingAzure = () => { |
There was a problem hiding this comment.
I'd rename this to 'getAzureKeys' for consistency
nicolas2bert
force-pushed
the
azure/get
branch
4 times, most recently
from
eb1040c
to
2a5c6c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FT: AZURE GET