Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTEGRATION [PR#5626 > development/8.8] Fixup on deleteObject #5634

Merged
merged 5 commits into from
Jul 15, 2024
Merged

INTEGRATION [PR#5626 > development/8.8] Fixup on deleteObject #5634

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d91853a
processBucketPolicy fixup for objectDelete
benzekrimaha Jul 15, 2024
e139406
Merge branch 'bugfix/CLDSRV-555-deleteObjects-policy-eval-fix' into t…
bert-e Jul 15, 2024
0cd10a7
Merge branch 'w/7.70/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix'…
bert-e Jul 15, 2024
22887f4
Merge branch 'w/8.6/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix' …
bert-e Jul 15, 2024
b72e918
Merge branch 'w/8.7/bugfix/CLDSRV-555-deleteObjects-policy-eval-fix' …
bert-e Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/api/multiObjectDelete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,8 +508,9 @@ function multiObjectDelete(authInfo, request, log, callback) {
if (bucketShield(bucketMD, 'objectDelete')) {
return next(errors.NoSuchBucket);
}
if (!isBucketAuthorized(bucketMD, 'objectDelete', canonicalID, authInfo, log, request,
request.actionImplicitDenies)) {
// The implicit deny flag is ignored in the DeleteObjects API, as authorization only
// affects the objects.
if (!isBucketAuthorized(bucketMD, 'objectDelete', canonicalID, authInfo, log, request)) {
log.trace("access denied due to bucket acl's");
// if access denied at the bucket level, no access for
// any of the objects so all results will be error results
Expand Down
Loading