Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/cldsrv 516 setup bucket apis for quotas #5552

Merged

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Apr 2, 2024

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Apr 2, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 2, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-516 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.21

Please check the Fix Version/s of CLDSRV-516, or the target
branch of this pull request.

lib/api/bucketDeleteQuota.js Outdated Show resolved Hide resolved
lib/api/bucketGetQuota.js Outdated Show resolved Hide resolved
lib/api/bucketGetQuota.js Outdated Show resolved Hide resolved
lib/api/bucketUpdateQuota.js Show resolved Hide resolved
lib/api/bucketUpdateQuota.js Outdated Show resolved Hide resolved
tests/functional/aws-node-sdk/test/quota/tooling.js Outdated Show resolved Hide resolved
tests/functional/aws-node-sdk/test/quota/tooling.js Outdated Show resolved Hide resolved
tests/functional/aws-node-sdk/test/quota/tooling.js Outdated Show resolved Hide resolved
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-516-setup-bucket-apis-for-quotas branch 5 times, most recently from 1b21089 to d2eafe4 Compare April 9, 2024 12:07
@benzekrimaha benzekrimaha marked this pull request as ready for review April 15, 2024 13:26
lib/api/bucketGetQuota.js Outdated Show resolved Hide resolved
lib/api/bucketDeleteQuota.js Show resolved Hide resolved
lib/api/bucketDeleteQuota.js Outdated Show resolved Hide resolved
lib/api/bucketDeleteQuota.js Outdated Show resolved Hide resolved
lib/api/bucketGetQuota.js Outdated Show resolved Hide resolved
lib/api/bucketUpdateQuota.js Outdated Show resolved Hide resolved
@williamlardier williamlardier force-pushed the improvement/CLDSRV-516-setup-bucket-apis-for-quotas branch 4 times, most recently from 693f5d8 to acfdc78 Compare May 2, 2024 12:42
@williamlardier williamlardier force-pushed the improvement/CLDSRV-516-setup-bucket-apis-for-quotas branch from acfdc78 to b369a47 Compare May 2, 2024 13:23
@williamlardier
Copy link
Contributor

williamlardier commented May 2, 2024

As discussed with @benzekrimaha , I rebased the PR with the latest changes, and formatted the commits with my suggestions.

Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benzekrimaha
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e May 3, 2024
@bert-e
Copy link
Contributor

bert-e commented May 3, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.8

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7

Please check the status of the associated issue CLDSRV-516.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit b369a47 into development/8.8 May 3, 2024
14 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-516-setup-bucket-apis-for-quotas branch May 3, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants