Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ZENKO-1317 AWS lifecycle compat #1659

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

bennettbuchanan
Copy link

Depends on scality/Arsenal#622.

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2018

Hello bennettbuchanan,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

@bennettbuchanan bennettbuchanan force-pushed the feature/ZENKO-1317/aws-lifecycle-compat branch from f5bc9be to be76cf2 Compare December 14, 2018 22:29
@bennettbuchanan bennettbuchanan force-pushed the feature/ZENKO-1317/aws-lifecycle-compat branch from be76cf2 to 834369a Compare December 17, 2018 19:49
@bennettbuchanan
Copy link
Author

Force pushed package.json updates to use new Arsenal commit hash.

@bennettbuchanan bennettbuchanan force-pushed the feature/ZENKO-1317/aws-lifecycle-compat branch from 834369a to c59fc73 Compare December 17, 2018 20:49
@bennettbuchanan
Copy link
Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2018

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4
  • development/8.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2018

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4
  • development/8.0

Please check the status of the associated issue ZENKO-1317.

Goodbye bennettbuchanan.

@bert-e bert-e merged commit c59fc73 into development/8.1 Dec 17, 2018
@bert-e bert-e deleted the feature/ZENKO-1317/aws-lifecycle-compat branch February 24, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants