Remove all uses of encodeURIcomponent #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add a test with one of the examples that throw in the JS docs. |
|
👍 |
encodeURIcomponent throws exceptions, so its replaced with queryString.escape . One test added to verify that queryString.escape does not throw an error.
|
Let' do an end-to-end test to ensure compatibility as MetaData uses bucketclient in its tests. I can create a temp. branch in MetaData and S3 to launch the test. |
|
https://github.com/nodejs/node/blob/v4.x/lib/querystring.js#L145 |
|
Looks like they actually landed the commit in 4.x last week 😕 |
|
Tests pass in 4.4.1 and fail in 4.4.4. I think they landed this change in 4.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodeURIcomponent throws exceptions, so its replaced with queryString.escape. This change is made in parallel with issue #528 in IronMan-S3.