Zookeeper Path handling #2561
Open
Zookeeper Path handling #2561
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 6 files with indirect coverage changes
@@ Coverage Diff @@
## development/8.7 #2561 +/- ##
===================================================
+ Coverage 69.67% 69.75% +0.08%
===================================================
Files 194 194
Lines 12819 12893 +74
===================================================
+ Hits 8931 8993 +62
- Misses 3878 3890 +12
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
benzekrimaha
force-pushed
the
improvement/BB-542-zookeeper-handling
branch
from
8f975b4
to
1056812
Compare
benzekrimaha
force-pushed
the
improvement/BB-542-zookeeper-handling
branch
from
93f65d3
to
d3f3a90
Compare
Changes: the zookeeperUrl was adapted based on the config to differenciate between S3C and Artesca please note that a new parameter has been added to ease the unit testing on the function , it has the default value of the zookeeperManager class. Issue : BB-542
benzekrimaha
force-pushed
the
improvement/BB-542-zookeeper-handling
branch
from
d3f3a90
to
1c59b2c
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Comment on lines
+25
to
+27
| sinon.stub(redis.prototype, 'connect').returns(Promise.resolve()); | ||
| sinon.stub(redis.prototype, 'on').returnsThis(); | ||
| sinon.stub(redis.prototype, 'quit').returns(Promise.resolve()); |
There was a problem hiding this comment.
Suggested change
| sinon.stub(redis.prototype, 'connect').returns(Promise.resolve()); | |
| sinon.stub(redis.prototype, 'on').returnsThis(); | |
| sinon.stub(redis.prototype, 'quit').returns(Promise.resolve()); | |
| sinon.stub(redis.prototype, 'connect').resolves(); | |
| sinon.stub(redis.prototype, 'on').returnsThis(); | |
| sinon.stub(redis.prototype, 'quit').resolves(); |
Comment on lines
+226
to
+236
| class MockZookeeperManager { | ||
| constructor(url, options, logger) { | ||
| zkManagerArgs = { url, options, logger }; | ||
| this.once = sinon.stub().callsFake((event, callback) => { | ||
| if (event === 'connected') { | ||
| callback(); | ||
| } | ||
| }); | ||
| this.removeAllListeners = sinon.stub(); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we should define this class outside of a describe
| }); | ||
|
|
||
| it('should append zookeeperPath to connectionString if this._queuePopulator.mongo does not exist', done => { | ||
| delete bbapi._queuePopulator.mongo; |
There was a problem hiding this comment.
As we should not rely on the order ot unit tests for them to pass, I think this should be reverted at the end of the test (or just mock the value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : BB-542