Fwdport 7.2 to rel/7.4 (formerly master) #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/dependencies
Call QueuePopulatorExtension.setBatch() every time new entries are received, because multiple readers can be intermingled sending their respective data, and although the LogReader class is managing a single reader, the extensions `batch` field is global to all readers, so it has to be set every time.
MathieuCassagne
previously approved these changes
Jan 29, 2018
philipyoo
previously approved these changes
Jan 29, 2018
jonathan-gramain
previously approved these changes
Feb 1, 2018
|
Hello @jonathan-gramain "r+": Success |
|
⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/18950 |
|
💔 ⌛ circleCI test timed out... |
|
Hello @jonathan-gramain "r-": Success |
jonathan-gramain
force-pushed
the
fwdport_7.2_to_master
branch
from
e877132
to
30a2613
Compare
ironman-machine
dismissed stale reviews from MathieuCassagne, philipyoo, and jonathan-gramain
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
JianqinWang
approved these changes
Feb 1, 2018
alexanderchan-scality
approved these changes
Feb 1, 2018
|
Hello @jonathan-gramain "r+": Success |
|
⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/18999 |
|
Hello @jonathan-gramain "r-": Success |
ghost
changed the title
ghost
changed the base branch from
This was referenced Feb 2, 2018
|
Merging synchronously scality/bucketclient#128 scality/cloudserver#1092 scality/MetaData#1317 scality/sproxydclient#136 scality/Arsenal#404 #170 scality/Integration#631 , scality/Federation#1310 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.