Delay-job-completion action: Stop delaying when tmate is not running #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit the wait loop when it is no longer possible for a user to connect and stop the delay.
tcarmet
approved these changes
Sep 8, 2023
oliviergaraud
approved these changes
Sep 8, 2023
Co-authored-by: Olivier Garaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: OS-668
The
delay-job-completionaction is intended to be paired with thessh-to-workeraction in order to sleep and prevent a job from completing and being torn down.There is no point in sleeping if the tmate process has been killed and a developer can no longer connect to the job.
This adds adds a check for tmate's PID in the action's sleep loop.