Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bugfix: S3C-2052 Add error functions" #887

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

bennettbuchanan
Copy link

This reverts commit 9d02f86.

In the course of testing a metadata orphan persisted when the data had been cleaned up after an error was returned by metadata (the operation later succeeded despite returning an error). We are reverting this change in anticipation of the 8.0 release as a data orphan would be preferable to a metadata orphan.

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2019

Hello bennettbuchanan,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

@bennettbuchanan
Copy link
Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2019

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4
  • development/7.5
  • stabilization/7.5.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2019

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4
  • development/7.5
  • stabilization/7.5.0

Please check the status of the associated issue S3C-2052.

Goodbye bennettbuchanan.

@bert-e bert-e merged commit 28415a5 into development/8.1 Aug 28, 2019
@bert-e bert-e deleted the bugfix/S3C-2052/revert-api-changes branch August 28, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants