Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTEGRATION [PR#550 > development/8.0] MD-661, ZENKO-945: fix delimiterMaster::filter #554

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

bert-e
Copy link
Contributor

@bert-e bert-e commented Aug 22, 2018

This pull request has been created automatically.
It is linked to its parent pull request #550.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.0/bugfix/ZENKO-945-delimitermaster-filter, please follow this
procedure:

 $ git fetch
 $ git checkout w/8.0/bugfix/ZENKO-945-delimitermaster-filter
 $ # <amend or cancel the changeset by _adding_ new commits>
 $ git push origin w/8.0/bugfix/ZENKO-945-delimitermaster-filter

Please always comment pull request #550 instead of this one.

Jeremy Desanlis and others added 2 commits August 22, 2018 11:10
The return values of the delimiterMaster::filter function are used by
its client, metadata back-end like the mongoClient or Metadata, to
implement a skipScan mechanism: after a number of consecutive SKIP
return values, the clients changes their dataset to the next key range.

This algo, by allowing to skip values unwanted in the results
efficiently, gives good performance to master version listing.

The previous algo was broken, preventing it client to perform the
skipScan: it returns ACCEPT for versions, reseting the SKIP counter of
clients.

This commit changes the return values of this function to allow
delimiter clients to use the skipScan mechanism.
@bert-e bert-e merged commit 879075e into development/8.0 Aug 22, 2018
@bert-e bert-e deleted the w/8.0/bugfix/ZENKO-945-delimitermaster-filter branch August 22, 2018 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant