Fixes flakiness in S3 functional tests with mongo backend #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrancurel
approved these changes
Apr 7, 2018
JianqinWang
approved these changes
Apr 7, 2018
alexanderchan-scality
approved these changes
Apr 7, 2018
philipyoo
approved these changes
Apr 7, 2018
philipyoo
reviewed
Apr 7, 2018
| @@ -440,6 +440,7 @@ class MongoClientInterface { | |||
| } | |||
| return cb(null, `{"versionId": "${objVal.versionId}"}`); | |||
| }); | |||
| return null; | |||
There was a problem hiding this comment.
Is the caller not expecting the cb to be invoked?
There was a problem hiding this comment.
Yeah I don't understand how this solves the issue.
|
Merging this but let's discuss what the issue is and how this solves it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b3103e1 that fixes versioning introduced some flakiness into the S3 functional tests with mongo backend. This reduces the flakiness on the tests.