Fix/stuck replication #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mongodb transform stream would never actually emit any objects to the extensions.
ssalaues
approved these changes
Apr 2, 2018
alexanderchan-scality
approved these changes
Apr 2, 2018
| const limit = params.limit || 10000; | ||
| const startIDandSeq = params.startSeq.toString().split('|'); | ||
| const startSeq = parseInt(startIDandSeq[0], 10) || 0; | ||
| lastEndID = startIDandSeq[1]; | ||
| const lastEndID = startIDandSeq[1]; |
There was a problem hiding this comment.
should this change the this.lastEndID? just wondering, in the the old code, the global lastEndID is reassigned.
There was a problem hiding this comment.
They are in 2 separate classes, and the global was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mongdb oplog consumer: