INTEGRATION [PR#1944 > development/8.1] Feature: ARSN-235 update object before deleting it #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object deletion no longer directly deletes the object, it first updates its metadata by setting the deletion flag and originOp then proceeds to deleting the object. This is done to keep a trace of the latest object metadata before deletion in the oplog, as oplog delete events don't hold that information. This information is needed for both Cold Storage and Bucket Notification We also add all the object metadata to the placeholder (PHD) master which wasn't previously the case, again this is done to keep the metadata in the oplog as a PHD might get directly deleted in the repair phase.
… tmp/octopus/w/8.1/feature/ARSN-235-update-object-before-deleting-it
Deletion flag serves showing that an object is in the process of beeing deleted, the object's metadata is updated with deletion flag set to true before deleting it to keep a trace of the latest metadata inside the oplog as normal mongo delete events don't contain any metadata.
The "isPHD" flag serves showing that a master object is in a temporary invalid state that gets repaired asynchronously after a certain period of time. The repair either updates the metadata or deletes the master object. This invalid state happens when deleting the last version of an object. Previously the "isPHD" flag was set directly inside the object metadata without going through the ObjectMD model, which is not ideal.
Codecov Report
@@ Coverage Diff @@
## development/8.1 #2010 +/- ##
===================================================
+ Coverage 63.83% 63.89% +0.06%
===================================================
Files 206 206
Lines 15593 15644 +51
Branches 3179 3187 +8
===================================================
+ Hits 9954 9996 +42
- Misses 5623 5632 +9
Partials 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bert-e
deleted the
w/8.1/feature/ARSN-235-update-object-before-deleting-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #1944.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/feature/ARSN-235-update-object-before-deleting-it, please follow thisprocedure:
$ git fetch $ git checkout w/8.1/feature/ARSN-235-update-object-before-deleting-it $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.1/feature/ARSN-235-update-object-before-deleting-itPlease always comment pull request #1944 instead of this one.