Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTEGRATION [PR#1975 > development/8.1] bugfix/ARSN-253 #1977

Merged

Conversation

bert-e
Copy link
Contributor

@bert-e bert-e commented Aug 2, 2022

This pull request has been created automatically.
It is linked to its parent pull request #1975.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars, please follow this
procedure:

 $ git fetch
 $ git checkout w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars
 $ # <amend or cancel the changeset by _adding_ new commits>
 $ git push origin w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars

Please always comment pull request #1975 instead of this one.

fixing the problem with unicode special chars by encoding them with URI
Problem was that our encoreURI function was not working properly for special chars
…al-unicode-chars' into w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars
…al-unicode-chars' into w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars
@KillianG KillianG force-pushed the w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars branch from 839d213 to e2af4fb Compare August 8, 2022 13:32
@KillianG KillianG force-pushed the w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars branch from e2af4fb to 69d33a3 Compare August 8, 2022 13:49
…al-unicode-chars' into w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars
@codecov-commenter
Copy link

Codecov Report

Merging #1977 (69d33a3) into development/8.1 (480f5a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 69d33a3 differs from pull request most recent head 9d8f479. Consider uploading reports for the commit 9d8f479 to get more accurate results

@@               Coverage Diff                @@
##           development/8.1    #1977   +/-   ##
================================================
  Coverage            63.78%   63.78%           
================================================
  Files                  206      206           
  Lines                15577    15578    +1     
  Branches              3125     3124    -1     
================================================
+ Hits                  9936     9937    +1     
  Misses                5625     5625           
  Partials                16       16           
Impacted Files Coverage Δ
lib/auth/v4/awsURIencode.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bert-e bert-e merged commit 9d8f479 into development/8.1 Aug 8, 2022
@bert-e bert-e deleted the w/8.1/bugfix/ARSN-253-issue-with-special-unicode-chars branch August 8, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants