Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTEGRATION [PR#1693 > development/8.1] bf: ARSN-57 log correct client ip #1695

Merged

Conversation

bert-e
Copy link
Contributor

@bert-e bert-e commented Jan 29, 2022

This pull request has been created automatically.
It is linked to its parent pull request #1693.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/bugfix/ARSN-57-correct-logging-client-ip, please follow this
procedure:

 $ git fetch
 $ git checkout w/8.1/bugfix/ARSN-57-correct-logging-client-ip
 $ # <amend or cancel the changeset by _adding_ new commits>
 $ git push origin w/8.1/bugfix/ARSN-57-correct-logging-client-ip

Please always comment pull request #1693 instead of this one.

Naren and others added 3 commits January 28, 2022 17:03
check request header 'x-forwarded-for' if there is no request
configuration.
…gging-client-ip' into w/8.1/bugfix/ARSN-57-correct-logging-client-ip
@codecov-commenter
Copy link

Codecov Report

Merging #1695 (49239cc) into development/8.1 (8d17fca) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           development/8.1    #1695      +/-   ##
===================================================
- Coverage            59.79%   59.78%   -0.01%     
===================================================
  Files                  190      190              
  Lines                12182    12187       +5     
===================================================
+ Hits                  7284     7286       +2     
- Misses                4898     4901       +3     
Impacted Files Coverage Δ
lib/s3routes/routes.js 14.00% <25.00%> (+0.45%) ⬆️
lib/policyEvaluator/requestUtils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d17fca...49239cc. Read the comment docs.

@bert-e bert-e merged commit 49239cc into development/8.1 Jan 29, 2022
@bert-e bert-e deleted the w/8.1/bugfix/ARSN-57-correct-logging-client-ip branch January 29, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants