INTEGRATION [PR#1649 > development/8.1] ARSN-21 Upgrade Node to 16 #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitri Bourreau <[email protected]>
Signed-off-by: Dimitri Bourreau <[email protected]>
Signed-off-by: Dimitri Bourreau <[email protected]>
Signed-off-by: Dimitri Bourreau <[email protected]>
Signed-off-by: Dimitri Bourreau <[email protected]>
Signed-off-by: Dimitri Bourreau <[email protected]>
Signed-off-by: Dimitri Bourreau <[email protected]>
Signed-off-by: Dimitri Bourreau <[email protected]>
…-to-16' into w/7.10/improvement/ARSN-21-Upgrade-Node-to-16
…de-Node-to-16' into w/8.1/improvement/ARSN-21-Upgrade-Node-to-16
….com:scality/Arsenal into w/8.1/improvement/ARSN-21-Upgrade-Node-to-16
miniscruff
reviewed
Jan 19, 2022
| return cbOnce(errors.InternalError.customizeDescription( | ||
| `read stream error: ${err.code}`)); | ||
| }); | ||
| dataStream.on('close', () => { |
There was a problem hiding this comment.
Close is now always called and not just called when an issue comes up, nodejs/node#20611
There was a problem hiding this comment.
@vrancurel Would you mind having a look at this one? Thank you.
@miniscruff Could you please create a JIRA ticket to add tests for this? Thank you.
nicolas2bert
approved these changes
Jan 19, 2022
jonathan-gramain
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #1649.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/improvement/ARSN-21-Upgrade-Node-to-16, please follow thisprocedure:
$ git fetch $ git checkout w/8.1/improvement/ARSN-21-Upgrade-Node-to-16 $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.1/improvement/ARSN-21-Upgrade-Node-to-16Please always comment pull request #1649 instead of this one.