Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ZENKO 2702 Use replica set config instead of rs0 #1248

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

miniscruff
Copy link
Contributor

We already had the replica set value in the config and was loading it but was using a fixed rs0 in place of the real value.

@bert-e
Copy link
Contributor

bert-e commented Aug 25, 2020

Hello miniscruff,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 25, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @jonathan-gramain.

Copy link
Contributor

@anurag4DSB anurag4DSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we create development/8.2 in Arsenal?

We are planning to concentrate on only Zenko v2.x
In the future if we have a bug in Zenko v1.x and we have to update arsenal in cloud server, this might break things.

I checked the ticket and it's fix version is only 2.x so I am guessing there is nothing planned for cloudsevrer dev/8.1.

@bert-e
Copy link
Contributor

bert-e commented Aug 26, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @jonathan-gramain.

The following reviewers are expecting changes from the author, or must review again:

@bert-e
Copy link
Contributor

bert-e commented Aug 26, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @jonathan-gramain.

@anurag4DSB
Copy link
Contributor

anurag4DSB commented Aug 26, 2020

Okay approved, after checking cloud server config and your PR summary :D.
But I think we should still make a development/8.2 for 2.x
what do you think?
CC @jonathan-gramain

@miniscruff
Copy link
Contributor Author

Shouldn't we create development/8.2 in Arsenal?

We are planning to concentrate on only Zenko v2.x
In the future if we have a bug in Zenko v1.x and we have to update arsenal in cloud server, this might break things.

I checked the ticket and it's fix version is only 2.x so I am guessing there is nothing planned for cloudsevrer dev/8.1.

The versioning of our packages are a mystery to me, I picked 8.1 as it was the default and @rahulreddy said that was fine over slack.

@anurag4DSB
Copy link
Contributor

Shouldn't we create development/8.2 in Arsenal?

We are planning to concentrate on only Zenko v2.x

In the future if we have a bug in Zenko v1.x and we have to update arsenal in cloud server, this might break things.

I checked the ticket and it's fix version is only 2.x so I am guessing there is nothing planned for cloudsevrer dev/8.1.

The versioning of our packages are a mystery to me, I picked 8.1 as it was the default and @rahulreddy said that was fine over slack.

This PR is good for 8.1. We do not have any breaking changes till now. I was considering the features we will add in the future specific to 2.x.

@bert-e
Copy link
Contributor

bert-e commented Aug 27, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @jonathan-gramain.

The following options are set: approve

@rahulreddy
Copy link
Collaborator

If you ask me I would prefer 9.0 but I don't want to break RING 9 convention. Since 8.1 didn't have any breaking changes, we kept it as-is. Let me ask the question in the channel and see what everyone thinks.

@scality scality deleted a comment from bert-e Aug 31, 2020
@scality scality deleted a comment from bert-e Aug 31, 2020
@bert-e
Copy link
Contributor

bert-e commented Sep 1, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @jonathan-gramain.

@scality scality deleted a comment from bert-e Sep 1, 2020
@miniscruff
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 1, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4
  • development/7.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 1, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4
  • development/7.8

Please check the status of the associated issue ZENKO-2702.

Goodbye miniscruff.

@bert-e bert-e merged commit b25867f into development/8.1 Sep 1, 2020
@bert-e bert-e deleted the bugfix/ZENKO-2702_hardcodedReplicaSetName branch September 1, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants