-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: ZENKO 2702 Use replica set config instead of rs0 #1248
bugfix: ZENKO 2702 Use replica set config instead of rs0 #1248
Conversation
Hello miniscruff,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include a mandatory approval from @jonathan-gramain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we create development/8.2 in Arsenal?
We are planning to concentrate on only Zenko v2.x
In the future if we have a bug in Zenko v1.x and we have to update arsenal in cloud server, this might break things.
I checked the ticket and it's fix version is only 2.x so I am guessing there is nothing planned for cloudsevrer dev/8.1.
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include a mandatory approval from @jonathan-gramain. The following reviewers are expecting changes from the author, or must review again: |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include a mandatory approval from @jonathan-gramain. |
Okay approved, after checking cloud server config and your PR summary :D. |
The versioning of our packages are a mystery to me, I picked 8.1 as it was the default and @rahulreddy said that was fine over slack. |
This PR is good for 8.1. We do not have any breaking changes till now. I was considering the features we will add in the future specific to 2.x. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include a mandatory approval from @jonathan-gramain. The following options are set: approve |
If you ask me I would prefer 9.0 but I don't want to break RING 9 convention. Since 8.1 didn't have any breaking changes, we kept it as-is. Let me ask the question in the channel and see what everyone thinks. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include a mandatory approval from @jonathan-gramain. |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZENKO-2702. Goodbye miniscruff. |
We already had the replica set value in the config and was loading it but was using a fixed
rs0
in place of the real value.