introduce new scaleway_ip_reverse_dns resource #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
paultyng
suggested changes
Oct 25, 2018
| @@ -32,6 +32,8 @@ func resourceScalewayIP() *schema.Resource { | |||
| "reverse": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| Computed: true, | |||
| Deprecated: "use scaleway_ip_reverse_dns resource instead", | |||
There was a problem hiding this comment.
You should modify the docs for scaleway_ip as well.
There was a problem hiding this comment.
good point, I’ll add the deprecation notice there too.
There was a problem hiding this comment.
updated! @paultyng PTAL
nicolai86
force-pushed
the
reverse-dns-deprecation
branch
from
457a127 to
988e87e
Compare
to be replaced with scaleway_ip_reverse_dns resource
nicolai86
force-pushed
the
reverse-dns-deprecation
branch
from
988e87e to
10ab0b1
Compare
paultyng
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some usecases like dynamic reverse dns result in circular dependencies
between
scaleway_ipandscaleway_serverresources.To break this cycle the
reverseattribute onscaleway_ipis going tobe deprecated, and instead a new
scaleway_ip_reverse_dnsresource ismade available, which allows the IP to be created before the reverse DNS
is persisted.
Tests for the new resource as well as old modified resource are green.
Once merged this will fix use cases like https://github.com/terraform-providers/terraform-provider-scaleway/issues/88