Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support concurrent server creation #72

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Jun 28, 2018

instead of blocking for the entire resource creation duration, only
block for the actual call to create/ update the scaleway_server
resource; do not block while polling for the resource state.

this should speed up creating multiple servers considerably.

according to @sieben this should be safe now.

closes #65

@nicolai86
Copy link
Contributor Author

all tests are green so I'm pulling this in optimistically.

@nicolai86 nicolai86 merged commit bb69cff into master Jun 29, 2018
@nicolai86 nicolai86 deleted the concurrent-server-creation branch June 29, 2018 04:04
@meyskens
Copy link
Contributor

meyskens commented Jul 7, 2018

Not sure if related but since this was released i tried to create 3 servers and every time only 1/3 booted the rest set itself to an off state, went back to 1.4.1 and it worked fine. If you prefer i can make a seperate issue for this.

@nicolai86
Copy link
Contributor Author

nicolai86 commented Jul 7, 2018

@meyskens this is most definitively related. I’m so sorry - can you create a new issue to track this?

@nicolai86
Copy link
Contributor Author

@meyskens if you open a bug please include a template which has this issue - I tried reproducing it locally with this template, but it worked without any issues:

provider "scaleway" {}

resource "scaleway_server" "base" {
  name = "test"

  count = 5
  image = "5faef9cd-ea9b-4a63-9171-9e26bec03dbc"
  type  = "C1"
  tags  = ["terraform-test"]
}

@nicolai86
Copy link
Contributor Author

after some digging it seems to be related to scaleway_volume_attachment usage. investigating further...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server creation appears to happen sequentially
2 participants