Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: change the way an ip is attached to a server #365

Merged
merged 13 commits into from
Dec 10, 2019
Merged

refactor!: change the way an ip is attached to a server #365

merged 13 commits into from
Dec 10, 2019

Conversation

jerome-quere
Copy link
Contributor

No description provided.

@ghost ghost added the size/L label Dec 9, 2019
QuentinBrosse
QuentinBrosse suggested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerome-quere we also need to change the documentation in:

  • Home page
  • scaleway_instance_server
  • scaleway_instance_ip

scaleway/resource_instance_server.go Outdated Show resolved Hide resolved
@ghost ghost added the documentation label Dec 9, 2019
@ghost ghost added size/XL and removed size/L labels Dec 9, 2019
kindermoumoute
kindermoumoute requested changes Dec 10, 2019
View reviewed changes
scaleway/resource_instance_ip.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuentinBrosse
QuentinBrosse approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere changed the title break: change the way an ip is attached to a server refactor!: change the way an ip is attached to a server Dec 10, 2019
@jerome-quere jerome-quere merged commit 1e895d3 into scaleway:master Dec 10, 2019
@jerome-quere jerome-quere deleted the breaking branch December 10, 2019 15:36
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
documentation instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerome-quere @kindermoumoute @QuentinBrosse @remyleone