Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object): import bucket by name #343

Merged

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Nov 27, 2019

  • Rename getS3ClientWithRegionAndID to getS3ClientWithRegionAndName as the resource ID il the name of the bucket.
  • Use aws-sdk-go constants for acl attribute validatation function.
  • Remove bucket-owner-read and bucket-owner-full-control canned ACL support as they are applied to objects and not buckets (source).
  • Remove log-delivery-write canned ACL support as it is not supported in the aws-sdk-go. We could re-add it if needed.

Closes #321

Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit dd748ac into scaleway:master Nov 27, 2019
@QuentinBrosse QuentinBrosse deleted the fix-object-bucket-import branch March 5, 2020 16:10
@remyleone remyleone added the object Object storage issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation object Object storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object storage import should be done from bucket_name
3 participants