Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rdb): instance resource #331

Merged
merged 4 commits into from
Nov 21, 2019
Merged

feat(rdb): instance resource #331

merged 4 commits into from
Nov 21, 2019

Conversation

kindermoumoute
Copy link
Contributor

@kindermoumoute kindermoumoute commented Nov 20, 2019 •
edited
Loading

depends on #332

@QuentinBrosse QuentinBrosse mentioned this pull request Nov 20, 2019
Closed
17 tasks
@kindermoumoute kindermoumoute changed the title [WIP] feat(rdb): instance resource feat(rdb): instance resource Nov 21, 2019
jerome-quere
jerome-quere suggested changes Nov 21, 2019
View reviewed changes
scaleway/resource_rdb_instance_beta.go Show resolved Hide resolved
scaleway/resource_rdb_instance_beta.go Outdated Show resolved Hide resolved
scaleway/resource_rdb_instance_beta.go Outdated Show resolved Hide resolved
scaleway/resource_rdb_instance_beta.go Outdated Show resolved Hide resolved
@jerome-quere
Copy link
Contributor

We need documentation page

@ghost ghost added the documentation label Nov 21, 2019
jerome-quere
jerome-quere approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit 35d84cd into scaleway:master Nov 21, 2019
@kindermoumoute kindermoumoute deleted the rdb branch November 21, 2019 14:04
@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicbourgois loicbourgois loicbourgois left review comments

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
dependencies documentation rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kindermoumoute @jerome-quere @loicbourgois @remyleone