Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): handle regional IDs properly #320

Merged
merged 1 commit into from
Nov 18, 2019
Merged

fix(k8s): handle regional IDs properly #320

merged 1 commit into from
Nov 18, 2019

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Nov 18, 2019

Signed-off-by: Patrik Cyvoct [email protected]

@ghost ghost added the size/XS label Nov 18, 2019
jerome-quere
jerome-quere approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere changed the title fix(k8s): always check for regional ID fix(k8s): handle regional ID properly Nov 18, 2019
@jerome-quere jerome-quere changed the title fix(k8s): handle regional ID properly fix(k8s): handle regional IDs properly Nov 18, 2019
@jerome-quere jerome-quere merged commit ef26e25 into scaleway:master Nov 18, 2019
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sh4d1 @jerome-quere @kindermoumoute @remyleone