Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

best effort commercial server type validation #23

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Oct 8, 2017

fetch the list of known server types on initialization and cache it to validate r/server types later.

closes #17

all server-related tests remain green with this change:

make testacc TESTARGS="-run='TestAccScalewayServer_'"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run='TestAccScalewayServer_' -timeout 120m
?   	github.com/terraform-providers/terraform-provider-scaleway	[no test files]
=== RUN   TestAccScalewayServer_importBasic
--- PASS: TestAccScalewayServer_importBasic (91.70s)
=== RUN   TestAccScalewayServer_Basic
--- PASS: TestAccScalewayServer_Basic (96.95s)
=== RUN   TestAccScalewayServer_ExistingIP
--- PASS: TestAccScalewayServer_ExistingIP (88.13s)
=== RUN   TestAccScalewayServer_Volumes
--- PASS: TestAccScalewayServer_Volumes (105.94s)
=== RUN   TestAccScalewayServer_SecurityGroup
--- PASS: TestAccScalewayServer_SecurityGroup (124.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-scaleway/scaleway	506.928s

fetch the list of known server types on initialization and cache it to
use it to validate r/server against it later.

closes #17
@nicolai86
Copy link
Contributor Author

Pulling this in optimistically.

@nicolai86 nicolai86 merged commit cfbaf7a into master Nov 18, 2017
@nicolai86 nicolai86 deleted the c/commercial-type-validation branch November 18, 2017 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server type inconsistent: "VC1S" => "X64-2GB"
1 participant